Add golangci-lint to CI. #947
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #947 +/- ##
===========================================
+ Coverage 59.21% 59.53% +0.32%
===========================================
Files 42 41 -1
Lines 5720 5689 -31
===========================================
Hits 3387 3387
+ Misses 1896 1865 -31
Partials 437 437
Continue to review full report at Codecov.
|
|
|
||
| issues: | ||
| # use these new lint checks on code since #2574 | ||
| new-from-rev: 99ab66fdadcd77fef4048bb2aa86cae1f06c6e08 |
There was a problem hiding this comment.
You'll want to remove this if you have already fixed all the linting issues in this codebase — this references a commit on the go-algorand repo that I used to ignore all lint issues before this commit. (Because it was too much work to fix all the issues in the code before that date)
There was a problem hiding this comment.
oh I see 99ab66f is a commit on indexer, well, never mind
There was a problem hiding this comment.
I should update the description.
.golangci.yml
Outdated
|
|
||
| issues: | ||
| # use these new lint checks on code since #2574 | ||
| new-from-rev: 988ad6384783701d0b78bed903ff1bc28277f05c |
There was a problem hiding this comment.
Is it a lot of work to make indexer clean for the error-level linters you've picked out? just curious.
There was a problem hiding this comment.
if we start from this commit, there are just a couple of errors.
|
@cce should we pull in this change also? algorand/go-algorand#3734 Looks like there were some side effects on go-algorand that might not apply to Indexer. |
|
sure, the gci linter is great! |
Summary
Add linting to project.