Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to webpack #247

Merged
merged 5 commits into from Nov 19, 2020
Merged

Switch to webpack #247

merged 5 commits into from Nov 19, 2020

Conversation

jasonpaulos
Copy link
Member

Use webpack instead of browserify to build our browser bundle. Advantages of this are:

  • More control over dependency versions. Browserify ships with a suite of node packages ported to the browser, but we have no control over specific versions. For instance, their assert module is stuck on an older version and broken for typed arrays.
  • Explicitly declaring dependencies. Now users who build their own browser bundles can use our library without creating a custom config. This includes React developers.
  • Better support for source maps. Source maps are much easier to produce to webpack, and I have enabled them to be generated.

There are some additional changes in this PR:

  • I switched dependencies from keccak to js-sha3 since keccak has problems bundling with webpack.
  • I removed the use of the assert package from our source code, since it crashes if process.env isn't defined, which is no longer the case without browserify.
  • Updated chromedriver, since a new stable version of chrome has been released.

Closes #244.

Copy link
Contributor

@EvanJRichard EvanJRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review? Because it already LGTM :shipit:

@jasonpaulos
Copy link
Member Author

Yep, it's ready now

@jasonpaulos jasonpaulos merged commit 5edd80f into develop Nov 19, 2020
@jasonpaulos jasonpaulos deleted the jason/webpack branch November 19, 2020 19:07
@jasonpaulos jasonpaulos mentioned this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack build error in algosdk 1.8.0
2 participants