From d28452a3faa791c0e5b16fdc44a333f7a96bc881 Mon Sep 17 00:00:00 2001 From: Ben Guidarelli Date: Fri, 24 Mar 2023 11:13:01 -0400 Subject: [PATCH 1/2] missed multisig in txn types --- algosdk/transaction.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/algosdk/transaction.py b/algosdk/transaction.py index dbb350c9..79770a08 100644 --- a/algosdk/transaction.py +++ b/algosdk/transaction.py @@ -3233,7 +3233,9 @@ def wait_for_confirmation( def create_dryrun( client: algod.AlgodClient, - txns: List[Union[SignedTransaction, LogicSigTransaction]], + txns: List[ + Union[SignedTransaction, LogicSigTransaction, MultisigTransaction] + ], protocol_version=None, latest_timestamp=None, round=None, From b4427140f8c883ec76a4de091540efb9a9e0f1b9 Mon Sep 17 00:00:00 2001 From: Ben Guidarelli Date: Mon, 27 Mar 2023 14:38:44 -0400 Subject: [PATCH 2/2] update types to use GenericSignedTransaction --- algosdk/transaction.py | 4 +--- algosdk/v2client/algod.py | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/algosdk/transaction.py b/algosdk/transaction.py index 79770a08..80123894 100644 --- a/algosdk/transaction.py +++ b/algosdk/transaction.py @@ -3233,9 +3233,7 @@ def wait_for_confirmation( def create_dryrun( client: algod.AlgodClient, - txns: List[ - Union[SignedTransaction, LogicSigTransaction, MultisigTransaction] - ], + txns: List["GenericSignedTransaction"], protocol_version=None, latest_timestamp=None, round=None, diff --git a/algosdk/v2client/algod.py b/algosdk/v2client/algod.py index 90434ee8..01010026 100644 --- a/algosdk/v2client/algod.py +++ b/algosdk/v2client/algod.py @@ -307,13 +307,13 @@ def status_after_block( return self.algod_request("GET", req, **kwargs) def send_transaction( - self, txn: "transaction.Transaction", **kwargs: Any + self, txn: "transaction.GenericSignedTransaction", **kwargs: Any ) -> str: """ Broadcast a signed transaction object to the network. Args: - txn (SignedTransaction or MultisigTransaction): transaction to send + txn (SignedTransaction, LogicSigTransaction, or MultisigTransaction): transaction to send request_header (dict, optional): additional header for request Returns: