New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to image is broken #2

Closed
Finkregh opened this Issue Sep 7, 2017 · 11 comments

Comments

Projects
None yet
2 participants
@Finkregh

Finkregh commented Sep 7, 2017

the link to the gitlab-logo is broken, as it uses a relative link:

<img src="lib/plugins/gitlabproject/images/gitlab.png" class="gitlab">
@algorys

This comment has been minimized.

Show comment
Hide comment
@algorys

algorys Sep 7, 2017

Owner

Ok, I'll have a look ASAP

Owner

algorys commented Sep 7, 2017

Ok, I'll have a look ASAP

@algorys algorys added the bug label Sep 7, 2017

@algorys

This comment has been minimized.

Show comment
Hide comment
@algorys

algorys Sep 11, 2017

Owner

Strange, because normally this link should be work...

When you try to reach http://WIKI_URL/lib/plugins/gitlabproject/images/gitlab.png, image is not displayed ?

Because, it's working very well on my test server and for other plugins. Check you have gitlab.png in gitlab plugin folder also.

Owner

algorys commented Sep 11, 2017

Strange, because normally this link should be work...

When you try to reach http://WIKI_URL/lib/plugins/gitlabproject/images/gitlab.png, image is not displayed ?

Because, it's working very well on my test server and for other plugins. Check you have gitlab.png in gitlab plugin folder also.

@Finkregh

This comment has been minimized.

Show comment
Hide comment
@Finkregh

Finkregh Sep 12, 2017

yep, but when i open /some/other/page then i get a relative link to 'lib/plugins/...'

Finkregh commented Sep 12, 2017

yep, but when i open /some/other/page then i get a relative link to 'lib/plugins/...'

@algorys

This comment has been minimized.

Show comment
Hide comment
@algorys

algorys Sep 13, 2017

Owner

@Finkregh Sorry, but I don't undestand what you say with /some/other/page ? Have you a screenshot please to understand your problem ?

Owner

algorys commented Sep 13, 2017

@Finkregh Sorry, but I don't undestand what you say with /some/other/page ? Have you a screenshot please to understand your problem ?

@Finkregh

This comment has been minimized.

Show comment
Hide comment
@Finkregh

Finkregh Sep 13, 2017

no problem ;-)

i open the wiki page via https://wiki/playground/playground.
the image there is linked via src="lib/plugins/... and it should be linked via src="https://wiki/lib/plugins/...

Finkregh commented Sep 13, 2017

no problem ;-)

i open the wiki page via https://wiki/playground/playground.
the image there is linked via src="lib/plugins/... and it should be linked via src="https://wiki/lib/plugins/...

@algorys

This comment has been minimized.

Show comment
Hide comment
@algorys

algorys Sep 13, 2017

Owner

Yes but normally Dokuwiki add the rest of url alone.... maybe it's due to https.

I'll try to find a way to add Wiki url to this link.

@Finkregh when you open deleoper tools in your browser and you hover the link, what url you have ?

Owner

algorys commented Sep 13, 2017

Yes but normally Dokuwiki add the rest of url alone.... maybe it's due to https.

I'll try to find a way to add Wiki url to this link.

@Finkregh when you open deleoper tools in your browser and you hover the link, what url you have ?

@algorys

This comment has been minimized.

Show comment
Hide comment
@algorys

algorys Sep 13, 2017

Owner

@Finkregh last version should solve your problem 😉

Owner

algorys commented Sep 13, 2017

@Finkregh last version should solve your problem 😉

@Finkregh

This comment has been minimized.

Show comment
Hide comment
@Finkregh

Finkregh Sep 18, 2017

yes, but i cant update via the DW gui because you changed things in the devel-branch...

Finkregh commented Sep 18, 2017

yes, but i cant update via the DW gui because you changed things in the devel-branch...

@Finkregh Finkregh closed this Sep 18, 2017

@algorys

This comment has been minimized.

Show comment
Hide comment
@algorys

algorys Sep 18, 2017

Owner

@Finkregh oups sorry, I merge right now.

Edit: you can now update plugin.

Owner

algorys commented Sep 18, 2017

@Finkregh oups sorry, I merge right now.

Edit: you can now update plugin.

@Finkregh

This comment has been minimized.

Show comment
Hide comment
@Finkregh

Finkregh Sep 19, 2017

in line 153 is another image-link :-)

Finkregh commented Sep 19, 2017

in line 153 is another image-link :-)

algorys added a commit that referenced this issue Sep 19, 2017

@algorys

This comment has been minimized.

Show comment
Hide comment
@algorys

algorys Sep 19, 2017

Owner

Sorry, I forget this case. Done.

Owner

algorys commented Sep 19, 2017

Sorry, I forget this case. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment