Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Hovering away no longer stops editing of editables

fixes #21
  • Loading branch information...
commit 35e4cf64afd14a12e432d9444decece3b20381e8 1 parent da38ac5
Ali Asaria authored
4 client/css/style.css
View
@@ -81,7 +81,7 @@ width: 16px; height: 16px;
}
.card-edit-form, .card-edit-form input, .card-edit-form textarea {
- border:none;
+ border: none;
font-size:inherit;
font-weight:inherit;
background-color:inherit;
@@ -95,6 +95,8 @@ width: 16px; height: 16px;
overflow: hidden;
resize: none;
width: 100%;
+ color: #330066;
+ color: #666;
}
3  client/lib/jquery-ui/development-bundle/ui/jquery-ui-1.8.9.custom.js
View
@@ -656,7 +656,8 @@ $.widget("ui.mouse", {
.bind('mousemove.'+this.widgetName, this._mouseMoveDelegate)
.bind('mouseup.'+this.widgetName, this._mouseUpDelegate);
- event.preventDefault();
+ //ali: fixing this http://bugs.jqueryui.com/ticket/4261
+ //event.preventDefault();
ali asaria Owner

badness happening here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
event.originalEvent.mouseHandled = true;
return true;
},
2  client/lib/jquery-ui/development-bundle/ui/jquery.ui.mouse.js
View
@@ -86,7 +86,7 @@ $.widget("ui.mouse", {
.bind('mousemove.'+this.widgetName, this._mouseMoveDelegate)
.bind('mouseup.'+this.widgetName, this._mouseUpDelegate);
- event.preventDefault();
+ //event.preventDefault();
event.originalEvent.mouseHandled = true;
return true;
},
10 client/lib/jquery.jeditable.js
View
@@ -285,16 +285,16 @@
} else if ('submit' == settings.onblur) {
input.blur(function(e) {
/* prevent double submit if submit was clicked */
- //t = setTimeout(function() {
+ t = setTimeout(function() {
form.submit();
- //}, 200);
+ }, 200);
});
//ali here: i hacked this in so that submit happens on mouseout too
- input.mouseout(function(e) {
+ input.blur(function(e) {
/* prevent double submit if submit was clicked */
- //t = setTimeout(function() {
+ t = setTimeout(function() {
form.submit();
- //}, 200);
+ }, 200);
});
} else if ($.isFunction(settings.onblur)) {
input.blur(function(e) {
11 client/script.js
View
@@ -171,6 +171,17 @@ function drawNewCard(id, text, x, y, rot, colour, sticker, animationspeed)
var card = $(h);
card.appendTo('#board');
+ //@TODO
+ //Draggable has a bug which prevents blur event
+ //http://bugs.jqueryui.com/ticket/4261
+ //So we have to blur all the cards and editable areas when
+ //we click on a card
+ //The following doesn't work so we will do the bug
+ //fix recommended in the above bug report
+ // card.click( function() {
+ // $(this).focus();
+ // } );
+
card.draggable(
{
snap: false,
4 views/layout.jade
View
@@ -6,7 +6,9 @@ html(lang="en")
<script src="/socket.io/socket.io.js"></script>
- <script src="/lib/jquery-ui/js/jquery-ui-1.8.9.custom.min.js"></script>
+ <!-- <script src="/lib/jquery-ui/js/jquery-ui-1.8.9.custom.min.js"></script> -->
+ <script src="/lib/jquery-ui/development-bundle/ui/jquery-ui-1.8.9.custom.js"></script>
+
<script src="/lib/jquery.jeditable.js"></script>
Please sign in to comment.
Something went wrong with that request. Please try again.