New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown support #96

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ldidry

ldidry commented Sep 14, 2016

With the help of marked

@ocdtrekkie

This comment has been minimized.

Show comment
Hide comment
@ocdtrekkie

ocdtrekkie Jan 18, 2017

This code works pretty great. I integrated it into 0.5 of the Sandstorm.io package of Scrumblr. I just had to grab some changes for marked.min.js to make links open in a new tab so that they'd work with Sandstorm's sandboxing: ocdtrekkie@6acde85 (This contains a hacked-together version of marked.js with a PR the marked.js author refused to merge from another user.)

It may be noteworthy that this functionality may be better outside Sandstorm as well. I doubt people who click links on their Kanban want to open them in the same tab.

ocdtrekkie commented Jan 18, 2017

This code works pretty great. I integrated it into 0.5 of the Sandstorm.io package of Scrumblr. I just had to grab some changes for marked.min.js to make links open in a new tab so that they'd work with Sandstorm's sandboxing: ocdtrekkie@6acde85 (This contains a hacked-together version of marked.js with a PR the marked.js author refused to merge from another user.)

It may be noteworthy that this functionality may be better outside Sandstorm as well. I doubt people who click links on their Kanban want to open them in the same tab.

@Framartin

This comment has been minimized.

Show comment
Hide comment
@Framartin

Framartin May 12, 2017

This PR should include the security fix of this issue when it will be ready (this is confidential for now).

Framartin commented May 12, 2017

This PR should include the security fix of this issue when it will be ready (this is confidential for now).

@Framartin

This comment has been minimized.

Show comment
Hide comment
@Framartin

Framartin Jul 6, 2017

@ldidry Can you include the fix to this XSS in this MR.

@ocdtrekkie I have created a MR in your repo to fix the Sandstorm version: ocdtrekkie#11

Framartin commented Jul 6, 2017

@ldidry Can you include the fix to this XSS in this MR.

@ocdtrekkie I have created a MR in your repo to fix the Sandstorm version: ocdtrekkie#11

@ldidry

This comment has been minimized.

Show comment
Hide comment
@ldidry

ldidry commented Jul 10, 2017

@Framartin Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment