Skip to content

fix: build release image from the version tag so its stamp matches#78

Merged
aliasunder merged 1 commit into
mainfrom
claude/vault-bootstrap-setup-TZgxO
Jun 8, 2026
Merged

fix: build release image from the version tag so its stamp matches#78
aliasunder merged 1 commit into
mainfrom
claude/vault-bootstrap-setup-TZgxO

Conversation

@aliasunder

Copy link
Copy Markdown
Owner

Problem

The published Docker image's baked package.json version lags the release tag by one. The v0.15.13 release shipped an image whose package.json reads 0.15.12 (confirmed: a fresh :latest pull on Apple Silicon ran the new multi-arch image but node -p require('/app/package.json').version returned 0.15.12).

Cause: deploy.yml's actions/checkout uses the default ref (github.sha). On a manual release, manual_release.yml runs bump-and-tag (bump package.json → commit release: vX → tag) and then calls deploy — but github.sha for the run is still the pre-bump dispatch commit. So the image is built from source where package.json is the previous version, yet tagged/shipped as the new one.

This is purely a version-stamp issue (the code is current), but it's misleading — the package.json version probe is an unreliable "which release am I on" signal, and it made diagnosing a stale-image problem murkier during testing.

Fix

Pin deploy.yml's checkout to the release tag:

- uses: actions/checkout@v6
  with:
    ref: v${{ inputs.version }}

bump-and-tag pushes the tag before deploy runs (deploy needs: bump-and-tag), so the ref always resolves. The image is then built from the bumped commit and stamps the correct version.

Safety for both callers

  • manual_release.yml (the affected path) — tag exists before deploy; now builds the bumped commit. ✅ fixes the lag.
  • auto_release.yml — triggered by the tag push, so its github.sha is already the bumped/tagged commit (it even asserts package.json == tag). Pinning to the same tag is a no-op. ✅ no regression.

One-line workflow change; affects future releases only.

🤖 Generated with Claude Code


Generated by Claude Code

deploy.yml checked out the default github.sha. On a manual release that is
the pre-bump dispatch commit, so the built image's package.json was stamped
one version behind the release it ships as (the v0.15.13 release shipped an
image reporting 0.15.12). Pin the checkout to the release tag (v<version>),
which bump-and-tag creates before deploy runs. auto_release is tag-triggered
and already builds the tagged commit, so this is a no-op on that path.

Generated with Claude Code
Co-authored-by: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aliasunder, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 36 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f56d2b6c-dd19-498d-8f35-76056da16e3f

📥 Commits

Reviewing files that changed from the base of the PR and between f2c276a and 9e64eee.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/vault-bootstrap-setup-TZgxO

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aliasunder aliasunder merged commit b67c47b into main Jun 8, 2026
6 checks passed
@aliasunder aliasunder deleted the claude/vault-bootstrap-setup-TZgxO branch June 8, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants