New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Collapse): fix nested collapse icon #421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 90.82% 90.83% +<.01%
==========================================
Files 241 241
Lines 13500 13501 +1
Branches 4160 4160
==========================================
+ Hits 12262 12263 +1
Misses 1220 1220
Partials 18 18
Continue to review full report at Codecov.
|
@tao1991123 please check this carefully! Will the PR have any bad impact on users? Someone who uses old css stylesheet and new js files |
@tao1991123 Is it possible to do that? Wouldn't users have to use both styles and js files from the same version? |
No, they don't. Users who use theme package( https://github.com/alibaba-fusion/next/blob/master/site/en-us/theme.md ) use both So version of css will always older than the js version( among the same minor verison ). Many users use it this way. Users should keep css and js version in the same minor version. |
@youluna means user writes css styles to overwrite the default style. Only one case that users overwrite .panel-expanded .icon {
xxxxx
} but new style is priorer than the old .panel .icon.icon-expand {
xxxx
} I reviewed and I think it's ok, you remove none of old classnames, it compatible. so I approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
close #416 |
No description provided.