From 0a44e711e5022b0f69c8c988753be9e1b1b0ff46 Mon Sep 17 00:00:00 2001
From: Tao He <linzhu.ht@alibaba-inc.com>
Date: Thu, 15 Jun 2023 15:40:17 +0800
Subject: [PATCH] Fixes the misuse of "continue-on-error" and
 "fail_ci_if_error". (#2904)

See also commit 612bd7f090f537b4d3efc37a896263421cffb5f1.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
---
 .github/workflows/gae.yml                           | 3 ++-
 .github/workflows/k8s-ci.yml                        | 3 ++-
 .github/workflows/local-ci.yml                      | 3 ++-
 .github/workflows/networkx-forward-algo-nightly.yml | 3 ++-
 .github/workflows/nightly.yml                       | 3 ++-
 python/setup.py                                     | 2 +-
 6 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/gae.yml b/.github/workflows/gae.yml
index e7d2a6b685e9..33430c16cf85 100644
--- a/.github/workflows/gae.yml
+++ b/.github/workflows/gae.yml
@@ -99,6 +99,7 @@ jobs:
 
     - name: Upload Coverage
       uses: codecov/codecov-action@v3
+      continue-on-error: true
       with:
         file: ./python/coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
diff --git a/.github/workflows/k8s-ci.yml b/.github/workflows/k8s-ci.yml
index c7b98a2822c2..a341cf1e5324 100644
--- a/.github/workflows/k8s-ci.yml
+++ b/.github/workflows/k8s-ci.yml
@@ -490,9 +490,10 @@ jobs:
 
       - name: Upload Coverage
         uses: codecov/codecov-action@v3
+        continue-on-error: true
         with:
           file: ./python/coverage.xml
-          continue-on-error: true
+          fail_ci_if_error: false
 
       - name: HDFS test
         env:
diff --git a/.github/workflows/local-ci.yml b/.github/workflows/local-ci.yml
index 6e15a95f8a43..9f5dabbc68c2 100644
--- a/.github/workflows/local-ci.yml
+++ b/.github/workflows/local-ci.yml
@@ -380,9 +380,10 @@ jobs:
     - name: Upload Coverage
       if: ${{ needs.changes.outputs.gae-python == 'true' || github.ref == 'refs/heads/main' }}
       uses: codecov/codecov-action@v3
+      continue-on-error: true
       with:
         file: ./coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
 
   networkx-basic-test:
     runs-on: ubuntu-20.04
diff --git a/.github/workflows/networkx-forward-algo-nightly.yml b/.github/workflows/networkx-forward-algo-nightly.yml
index 93ee5b079519..36ee5312c9af 100644
--- a/.github/workflows/networkx-forward-algo-nightly.yml
+++ b/.github/workflows/networkx-forward-algo-nightly.yml
@@ -47,6 +47,7 @@ jobs:
 
     - name: Upload Coverage
       uses: codecov/codecov-action@v3
+      continue-on-error: true
       with:
         file: ./python/coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index 9af43ce485d7..36571b6d1748 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -71,6 +71,7 @@ jobs:
     - name: Upload Coverage
       uses: codecov/codecov-action@v3
       if: matrix.os == 'ubuntu-20.04'
+      continue-on-error: true
       with:
         file: ./python/coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
diff --git a/python/setup.py b/python/setup.py
index bcfc4e7ba486..c6aefdb41ae3 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -228,7 +228,7 @@ def build_learning_engine():
     library_dirs.append(ROOT_PATH + "/graphlearn/built/lib")
 
     extra_compile_args.append("-D__USE_XOPEN2K8")
-    extra_compile_args.append("-std=c++11")
+    extra_compile_args.append("-std=c++17")
     extra_compile_args.append("-fvisibility=hidden")
 
     libraries.append("graphlearn_shared")