Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests under frontend module #883

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Fix unit tests under frontend module #883

merged 2 commits into from
Oct 8, 2021

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Oct 8, 2021 •
edited by yecol
Loading

fix unit tests under frontend module:

  1. represent int type as VT_INT instead of VT_INTEGER in old version
  2. initialize CostDataStatistics before using it to fix some bugs

to replay:
cd interactive_engine/src/frontend && mvn clean package (skip tests in other modules)

Related issue number

Partially fixes #712

@yecol yecol merged commit 26d320b into main Oct 8, 2021
@siyuan0322 siyuan0322 deleted the fix_unit_tests branch November 11, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yecol yecol yecol approved these changes

@siyuan0322 siyuan0322 Awaiting requested review from siyuan0322

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] make interactive_engine pass all unit tests
2 participants
@shirly121 @yecol