From a63fea36491761d2df57ae705cf0e733b43e970d Mon Sep 17 00:00:00 2001 From: pandaapo <35672972+pandaapo@users.noreply.github.com> Date: Thu, 5 Jan 2023 20:30:21 +0800 Subject: [PATCH] Fix potential connection leak bug when closing NacosDataSource (#2962) --- .../csp/sentinel/datasource/nacos/NacosDataSource.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sentinel-extension/sentinel-datasource-nacos/src/main/java/com/alibaba/csp/sentinel/datasource/nacos/NacosDataSource.java b/sentinel-extension/sentinel-datasource-nacos/src/main/java/com/alibaba/csp/sentinel/datasource/nacos/NacosDataSource.java index ee5c719065..caade5cf30 100644 --- a/sentinel-extension/sentinel-datasource-nacos/src/main/java/com/alibaba/csp/sentinel/datasource/nacos/NacosDataSource.java +++ b/sentinel-extension/sentinel-datasource-nacos/src/main/java/com/alibaba/csp/sentinel/datasource/nacos/NacosDataSource.java @@ -145,6 +145,12 @@ public String readSource() throws Exception { public void close() { if (configService != null) { configService.removeListener(dataId, groupId, configListener); + try { + configService.shutDown(); + } catch (Exception e) { + RecordLog.warn("[NacosDataSource] Error occurred when closing Nacos data source", e); + e.printStackTrace(); + } } pool.shutdownNow(); }