After suspending the job, executing bg causes Arthas to exit #694
Milestone
Comments
|
在 bg 执行时，有可能出现这种情况： |
|
实际上是由 #410 引起的，因为配置了一个 public void readline(String prompt, Handler<String> lineHandler, Handler<Completion> completionHandler) {
if (conn.getStdinHandler() != echoHandler) {
throw new IllegalStateException();
}
if (inReadline) {
throw new IllegalStateException();
}
inReadline = true;
readline.readline(conn, prompt, new RequestHandler(this, lineHandler), new CompletionHandler(completionHandler, session));
}因为job有多种状态，所以当job在切换状态时，可能需要保证在 public enum ExecStatus {
/**
* The job is ready, it can be running or terminated.
*/
READY,
/**
* The job is running, it can be stopped or terminated.
*/
RUNNING,
/**
* The job is stopped, it can be running or terminated.
*/
STOPPED,
/**
* The job is terminated.
*/
TERMINATED
}另外，可能目前的 private void handleBackground(List<CliToken> tokens) {
String arg = TokenUtils.findSecondTokenText(tokens);
Job job;
if (arg == null) {
job = shell.getForegroundJob();
} else {
job = shell.jobController().getJob(getJobId(arg));
}
if (job == null) {
term.write(arg + " : no such job\n");
shell.readline();
} else {
if (job.status() == ExecStatus.STOPPED) {
job.resume(false);
term.echo(shell.statusLine(job, ExecStatus.RUNNING));
shell.readline();
} else {
term.write("job " + job.id() + " is already running\n");
shell.readline();
}
}
}在 |
|
看了下 vertx-shell 里的实现，bg后的确调用了 |
hengyunabc
added a commit
that referenced
this issue
May 14, 2019
|
找到最根本原因是 |
|
修复的测试包： arthas-3.1.1-SNAPSHOT-bin.zip |
XhinLiang
pushed a commit
to XhinLiang/arthas-mvel
that referenced
this issue
Aug 5, 2019
lzc-alioo
pushed a commit
to lzc-alioo/arthas
that referenced
this issue
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
用 arthas-demo 来测试：
先执行
watch demo.MathGame primeFactors target &。再执行 jobs ，得到job id。 再执行
ctrl + z挂起job，再执行 bg jobId ，Arthas就会马上退出。The text was updated successfully, but these errors were encountered: