Skip to content

Conversation

@XenoAmess
Copy link
Contributor

No description provided.

@XenoAmess XenoAmess changed the title NPE in SpringStatManager bug: NPE in SpringStatManager Sep 10, 2022
@XenoAmess XenoAmess force-pushed the NPE_in_SpringStatManager branch from 361eaad to 5974073 Compare October 9, 2022 20:36
@codecov-commenter
Copy link

Codecov Report

Base: 58.94% // Head: 58.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5974073) compared to base (d92126a).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4525   +/-   ##
=========================================
  Coverage     58.94%   58.94%           
+ Complexity    26910    26909    -1     
=========================================
  Files          1268     1268           
  Lines        122755   122756    +1     
  Branches      23123    23124    +1     
=========================================
+ Hits          72355    72356    +1     
+ Misses        41381    41380    -1     
- Partials       9019     9020    +1     
Impacted Files Coverage Δ
...a/druid/support/spring/stat/SpringStatManager.java 57.50% <50.00%> (-1.48%) ⬇️
.../java/com/alibaba/druid/util/JdbcSqlStatUtils.java 58.62% <0.00%> (-3.45%) ⬇️
...n/java/com/alibaba/druid/pool/DruidDataSource.java 71.98% <0.00%> (ø)
...baba/druid/pool/DruidDataSourceStatLoggerImpl.java 51.72% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lizongbo
Copy link
Collaborator

这里目前实际add的stat只有SpringStat类型的,不会触发抛异常的场景,但是先前代码写得绕,所以ide可能会提示该变量可能为null

@lizongbo lizongbo merged commit 4e6fc39 into alibaba:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants