Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iceworks] fix: 显性依赖 mkdirp #1766

Merged
merged 1 commit into from Apr 8, 2019
Merged

Conversation

@alvinhui
Copy link
Collaborator

alvinhui commented Apr 8, 2019

No description provided.

@alvinhui alvinhui requested a review from chenbin92 Apr 8, 2019
@@ -27,6 +27,7 @@
"kebab-case": "^1.0.0",
"line-by-line": "^0.1.6",
"lodash.orderby": "^4.6.0",
"mkdirp": "^0.5.1",

This comment has been minimized.

Copy link
@chenbin92

chenbin92 Apr 8, 2019

Collaborator
  1. 这里之前没有显性依赖 mkdirp,你那边是遇到什么问题发现这个没有依赖的?
  2. renderermain 文件下的 package.json 依赖你现在是怎么区分的呢,如果同一个依赖是否只需要依赖一份

This comment has been minimized.

Copy link
@alvinhui

alvinhui Apr 8, 2019

Author Collaborator
  1. 从 yarn.lock 来看,mkdirp 是被 write 依赖,write 是被 @icedesign/template-builder 依赖;从 下面两次 commit 来看, @noyobo 先初始化了项目(生成了 package.json),再调用了 yarn install 生成了 yarn.lock 。在第一个 commit 中,项目中的 custom-block.js 已经显性依赖了 mkdirp ,但 mkdirp 却没有出现在项目的 package.json 的 dependencies 中,这是一个错误。
  2. gulpfile.js 来看现在 app 和 renderer 的打包逻辑是分开的,所以应该独立有自己的依赖。
@chenbin92 chenbin92 merged commit 652ea97 into iceworks/release-2.19.0 Apr 8, 2019
4 checks passed
4 checks passed
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@delete-merged-branch delete-merged-branch bot deleted the iceworks/mkdirp branch Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.