Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI is still available when i set nacos.core.auth.enabled=true and Nacos started successfully in cluster mode. #4181

Closed
twogozi opened this issue Nov 9, 2020 · 10 comments
Assignees
Labels
Milestone

Comments

@twogozi
Copy link

@twogozi twogozi commented Nov 9, 2020

OpenAPI is still available when i set nacos.core.auth.enabled=true and Nacos started successfully in cluster mode.
Nacos V1.3.0

@KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Nov 9, 2020

how to display your nacos cluster? docker? tar or zip?

Loading

@twogozi
Copy link
Author

@twogozi twogozi commented Nov 9, 2020

how to display your nacos cluster? docker? tar or zip?

Zip

Loading

@KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Nov 10, 2020

Choose any node has a try with API curl -X GET ip:port/nacos/v1/ns/service?serviceName=xxx.

If return 403 means your auth open successfully.

Loading

@twogozi
Copy link
Author

@twogozi twogozi commented Nov 10, 2020

Choose any node has a try with API curl -X GET ip:port/nacos/v1/ns/service?serviceName=xxx.

If return 403 means your auth open successfully.

My nacos configuration as follows:
1.server.servlet.contextPath=/
2.server.port=8850
3.nacos.core.auth.enabled=true
All other configurations are default and i have 3 nodes.

It returns "true" when i try to use API curl -X POST http://127.0.0.1:8850/v1/cs/configs?dataId=nacos.cfg.dataId&group=test&content=helloWorld.

It returns "helloWorld" when i try to use API curl -X GET http://127.0.0.1:8850/v1/cs/configs?dataId=nacos.cfg.dataId&group=test.

Loading

@wangweizZZ
Copy link
Collaborator

@wangweizZZ wangweizZZ commented Nov 10, 2020

I think server.servlet.contextPath=/ trigger the error . the logic in ControllerMethodsCache is not good , i will fix it

Loading

@twogozi
Copy link
Author

@twogozi twogozi commented Nov 11, 2020

I think server.servlet.contextPath=/ trigger the error . the logic in ControllerMethodsCache is not good , i will fix it

i hope you will let me know when you fixed it so i can upgrade my nacos cluster.
thanks.

Loading

@wangweizZZ
Copy link
Collaborator

@wangweizZZ wangweizZZ commented Nov 11, 2020

Maybe you can avoid the error by avoiding the use of server.servlet.contextPath=/, I will fix it as soon as possible

Loading

@wangweizZZ
Copy link
Collaborator

@wangweizZZ wangweizZZ commented Nov 11, 2020

Need more pr to fix it completely

Loading

@wangweizZZ wangweizZZ reopened this Nov 11, 2020
@KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Nov 11, 2020

ok

Loading

penghao03 added a commit to penghao03/nacos that referenced this issue Nov 14, 2020
wangweizZZ added a commit to wangweizZZ/nacos that referenced this issue Nov 24, 2020
wangweizZZ added a commit to wangweizZZ/nacos that referenced this issue Nov 26, 2020
@paderlol paderlol linked a pull request that will close this issue Nov 27, 2020
5 tasks
paderlol pushed a commit that referenced this issue Nov 27, 2020
* [ISSUE-#4181] Just use ContextPathUtil normalize ContextPath value

* [ISSUE-#4181] add some test cases
KomachiSion added a commit that referenced this issue Dec 3, 2020
* [ISSUE-#4262] Fix public namespace permission problem (#4273)

* fix public namespace permission problem

* move NamespaceUtilTest to common module

* [ISSUE-#4232] Use EnvUtil to replace ApplicationUtils about env operation (#4281)

* use EnvUtil to replace ApplicationUtils about env operation

* remove unuse import

* remove unuse import

* remove profile usage

* [ISSUE-#4294] Use EnvUtils.setEnvironment to replace ApplicationUtils.injectEnvironment (#4295)

* use EnvUtils.setEnvironment to replace ApplicationUtils.injectEnvironment.

* remove unuseful import

* remove unuseful import

* refactor: refactor issue #4291 (#4292)

* remove env operation code in ApplicationUtils (#4298)

* refactor issue #4275 (#4299)

* when auth open, use resource parser cache, not use reflect newInstance every time. (#4287)

* [ISSUE-#4256] Just inject environment in StartingSpringApplicationRunListener (#4257)

* just inject environment in StartingSpringApplicationRunListener

* make nacosStartingListener is decoupling with springApplicationRunListener.

* add api doc

* refactor. transfer nacos listeners to SpringApplicationRunListener.

* remove unuseful import

* add doc info

* [ISSUE #4311] Fix Derby data source related SQL LIMIT exception (#4313)

* for #4311,Fixed Derby data source related SQL LIMIT exception.

* fix code style.

* code format.

* [ISSUE-#4310] Delete the main function only for testing (#4312)

* [ISSUE #4320] Fixing the Naming consistency module could not start in cluster mode (#4321)

* refactor: refactor issue #4291

* fix: fixing the Naming consistency module could not start in cluster mode

* fix service list can not search by groupName only (#4308)

* fix service list can not search by groupName only

* fix service list can not search by groupName only

* fix checkStyle

* add ut for NamingUtils

* [ISSUE-#4258]  Fix wrong path when -Dspring.config.location not set (#4259)

* fix spring.config.location is nullapplication.properties when -Dspring.config.location is not set in env

* fix wrong path when -Dspring.config.location not set

* modify default file resource method name

* fix "/" magic value

* change the way of get file

* not judge pathSplit by self, use Paths.get(a, b);

* when spring.config.location is not set, use {nacos.home}/conf/application.properties to cover it.

* refactor code

* code quality enhance

* just use two level to load conf. {spring.config.location}/application.properties -> classpath:/application.properties

* code clean

* Upgrade jraft to 1.3.5 (#4339)

* 升级jraft到1.3.5以支持IPv6, 调整 NamingUtilsTest 代码格式以解决checkstyle问题

* 删除测试类的类注释

* [ISSUE-#4342] Fix nacos.core.protocol.raft.data.read_index_type isn't effect (#4343)

* fix nacos.core.protocol.raft.data.read_index_type=ReadOnlyLeaseBased isn't effect and enhance log hint

* define ReadOnlyOption param name just by self

* [ISSUE-#4333]Add MapRowMapper to RowMapperManager (#4334)

* for #4311,Fixed Derby data source related SQL LIMIT exception.

* Revert "for #4311,Fixed Derby data source related SQL LIMIT exception."

This reverts commit 49188f1

* fix #4333.

* Remove case conversion.

* [ISSUE-#4181]  Normalize ContextPath value in client-side (#4326)

* [ISSUE-#4181] Just use ContextPathUtil normalize ContextPath value

* [ISSUE-#4181] add some test cases

* fix styles at the button '新建命名空间' (#4362)

* [ISSUE-#4346] Fix import code (#4347)

* remove import.*

* transfer first_pre to final static variable

* use NamingBase.Xxx to replace constant

* reuse cliClientService (#4375)

* Sync code from upstream/develop

Co-authored-by: 赵延 <1060026287@qq.com>
Co-authored-by: liaochuntao <liaochuntao@live.com>
Co-authored-by: zhuhao <yczhuhaogg@gmail.com>
Co-authored-by: mai.jh <maijh97@gmail.com>
Co-authored-by: 孙继峰 <sun.jifeng@outlook.com>
Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com>
Co-authored-by: 邪影oO <213539@qq.com>
Co-authored-by: Gagharv <wwfortunate@gmail.com>
Co-authored-by: iochenlei <iochenlei@gmail.com>
@wangweizZZ
Copy link
Collaborator

@wangweizZZ wangweizZZ commented Dec 8, 2020

Because some front-end resources currently have hard-coded the path contextPath, it is recommended to use /nacos as the contextPath, and try not to use '/' . Related requirements can be controlled by components such as nginx

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants