Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates the default time zone for interface results #4073

Merged
merged 1 commit into from Nov 9, 2020

Conversation

@sanxun0325
Copy link
Collaborator

@sanxun0325 sanxun0325 commented Oct 27, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

修正config相关接口返回时间时区-8的问题。例如获取配置历史列表查询以及历史配置详情等,接口中返回的(lastModifiedTime)最后修改时间字段比真正操作时间少8小时。

原因:spring转json的默认实现jackson中会根据时区去转换时间,而jackson的默认时区跟国内应该是相差8小时,所以在时间换算上自动减去了8小时。

相关链接:https://my.oschina.net/u/4391021/blog/3580942

Brief changelog

添加spring.jackson.time-zone=Asia/Shanghai 配置

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
@KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Oct 28, 2020

Can we get the time zone from the system? Specify it in default conf file may not great.

Loading

@sanxun0325
Copy link
Collaborator Author

@sanxun0325 sanxun0325 commented Oct 28, 2020

Can we get the time zone from the system? Specify it in default conf file may not great.

I think it's better to get the time zone in the system,I'm going to try to solve it

Loading

@sanxun0325 sanxun0325 force-pushed the fix_interface_time_zone branch from b08d108 to 88fc1c6 Nov 2, 2020
@KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Nov 4, 2020

CI failed due to check style not pass.Please check it.

BTW, can you add some unit test?

Loading

@KomachiSion KomachiSion merged commit fb61648 into alibaba:develop Nov 9, 2020
2 checks passed
Loading
@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants