Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TLS config params can be setup in the file #1126

Merged

Conversation

yyb196
Copy link
Collaborator

@yyb196 yyb196 commented Apr 13, 2018

Signed-off-by: Frank Yang yyb196@gmail.com

Ⅰ. Describe what this PR did

make TLS config params can be setup in the config file which introduce by falg --config-file

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Ace-Tang

@codecov-io
Copy link

Codecov Report

Merging #1126 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   15.74%   15.74%   -0.01%     
==========================================
  Files         172      172              
  Lines        9648     9630      -18     
==========================================
- Hits         1519     1516       -3     
+ Misses       8020     8005      -15     
  Partials      109      109
Impacted Files Coverage Δ
client/client.go 30% <0%> (-9.4%) ⬇️
pkg/kernel/kernel.go 72.72% <0%> (-7.28%) ⬇️
cli/cli.go 0% <0%> (ø) ⬆️
ctrd/client.go 0% <0%> (ø) ⬆️

…pecified

Signed-off-by: Frank Yang <yyb196@gmail.com>
@Ace-Tang
Copy link
Contributor

LGTM.

Since encoding/json cannot do the trick with ">some>deep>childnode" like encoding/xml can do. Nested structs is the way to go.

I want to re-implement daemon config merge function.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 16, 2018
@allencloud allencloud merged commit dd50f1a into AliyunContainerService:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants