test: add new checkpoint for apis/opts/config/ulimit.go #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2645 +/- ##
=========================================
Coverage ? 69.66%
=========================================
Files ? 283
Lines ? 18891
Branches ? 0
=========================================
Hits ? 13161
Misses ? 4261
Partials ? 1469
|
|
@WillSmisi , please make ci pass, and the change looks good to me |
Ok! Thank you! |
fuweid
suggested changes
Jan 8, 2019
Signed-off-by: WillSmisi <764947976@qq.com>
|
@fuweid I have done it and all checks have passed. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: WillSmisi 764947976@qq.com
Ⅰ. Describe what this PR did
test: add new checkpoint for apis/opts/config/ulimit.go
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews