Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loading of common locale optional #76

Closed
MikeMcElroy opened this issue Aug 2, 2018 · 1 comment
Closed

Make loading of common locale optional #76

MikeMcElroy opened this issue Aug 2, 2018 · 1 comment

Comments

@MikeMcElroy
Copy link

It shouldn't be required that the package go out to a third-party CDN. It'd be nice to be able to specify the COMMON_LOCALE_DATA_URLS or be able to bundle an entire locale package in with the initialization. Something like:

intl.init({
  currentLocale: 'en-US',
  locales: {
    'en-US': { ... }
  },
  localeUrls: {
    'en-US': 'https://nonexistentUrl.cdn.com/localedata/en-us.json'
  },
  localeData: {
    'en-US': { ... }
  }
})
@cwtuan
Copy link
Collaborator

cwtuan commented Aug 5, 2018

@cwtuan cwtuan closed this as completed Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants