This repository was archived by the owner on Jan 10, 2023. It is now read-only.
sanitize label values for invalid utf-8#42
Merged
alicebob merged 1 commit intoalicebob:masterfrom May 20, 2020
Merged
Conversation
Owner
|
Looks good, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we encountered a problem with the exporter and utf-8 labels. When label value is not a valid utf-8 the prometheus client rejects it and exporter panics. We had invalid utf-8 value in the set name. This is certainly not a common issue but I think it is better to handle it if Aerospike server accepts it.
I will add this change also to this project https://github.com/aerospike/aerospike-prometheus-exporter/blob/master/watcher_sets.go after it will be merged here.