Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LMOVE #245

Merged
merged 1 commit into from Jan 19, 2022
Merged

Implement LMOVE #245

merged 1 commit into from Jan 19, 2022

Conversation

btwear
Copy link
Contributor

@btwear btwear commented Jan 13, 2022

Hi, I found there is no LMOVE command currently, so I implement it with tests.
Most of my works are based on RPOPLPUSH implementation.

@alicebob
Copy link
Owner

alicebob commented Jan 13, 2022 via email

@btwear
Copy link
Contributor Author

btwear commented Jan 14, 2022

@alicebob
Sure! I just pushed a amend commit with integration test.

@alicebob
Copy link
Owner

What a funny redis command. PR looks good when doing a basic read over it, will have a proper look soon.

@alicebob alicebob merged commit b821ff3 into alicebob:master Jan 19, 2022
1 check passed
@alicebob
Copy link
Owner

great PR, thanks!

Merged in master, will make it a release it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants