Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison for unsigned >= 0 in devices/aliceHLTwrapper/Component.cxx #90

Closed
ktf opened this issue Nov 16, 2015 · 2 comments
Closed

Comparison for unsigned >= 0 in devices/aliceHLTwrapper/Component.cxx #90

ktf opened this issue Nov 16, 2015 · 2 comments

Comments

@ktf
Copy link
Member

ktf commented Nov 16, 2015

@matthiasrichter looks like you have a tautological comparison at line 267 of devices/aliceHLTwrapper/Component.cxx:

>>  if (outputBlockCnt >= 0) {

where outputBlockCnt is unsigned. Shall we just drop the check?
@matthiasrichter
Copy link
Collaborator

sorry for the slow response, I will fix it now and make a pull request

matthiasrichter added a commit to matthiasrichter/AliceO2 that referenced this issue Nov 25, 2015
@matthiasrichter
Fix for GH issue AliceO2Group#90
6538569 
Removing  tautological comparison which was introduced in
commit a658a35
Author: Matthias Richter <Matthias.Richter@scieq.net>
Date:   Thu Mar 19 21:55:30 2015 +0100

    forwarding event header also if there are no output blocks; adjusting conditions for warning messages
@ktf
Copy link
Member Author

ktf commented Dec 3, 2015

Thanks. For the record, if you say "Fix #90" it actually closes the issue as well and adds a link.

MohammadAlTurany pushed a commit that referenced this issue Jan 13, 2016
@matthiasrichter @MohammadAlTurany
Fix for GH issue #90
352d8a3 
Removing  tautological comparison which was introduced in
commit a658a35
Author: Matthias Richter <Matthias.Richter@scieq.net>
Date:   Thu Mar 19 21:55:30 2015 +0100

    forwarding event header also if there are no output blocks; adjusting conditions for warning messages
mikesas pushed a commit to mikesas/AliceO2 that referenced this issue Dec 13, 2022
@jgrosseo
Task to check consistency of data model tables (AliceO2Group#90)
2dde2ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ktf @MohammadAlTurany @matthiasrichter