Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance package rule #43

Merged
merged 4 commits into from Apr 23, 2018
Merged

Enhance package rule #43

merged 4 commits into from Apr 23, 2018

Conversation

QilongZhang
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 178

  • 25 of 31 (80.65%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 32.021%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sofa-ark-parent/core/common/src/main/java/com/alipay/sofa/ark/common/util/ClassUtils.java 8 9 88.89%
sofa-ark-parent/support/ark-plugin-maven-plugin/src/main/java/com/alipay/sofa/ark/plugin/mojo/ArkPluginMojo.java 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
sofa-ark-parent/support/ark-plugin-maven-plugin/src/main/java/com/alipay/sofa/ark/plugin/mojo/ArkPluginMojo.java 2 0.0%
Totals Coverage Status
Change from base Build 176: 0.4%
Covered Lines: 1106
Relevant Lines: 3454
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 21, 2018 •
edited

Pull Request Test Coverage Report for Build 183

  • 25 of 31 (80.65%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 32.041%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sofa-ark-parent/core/common/src/main/java/com/alipay/sofa/ark/common/util/ClassUtils.java 8 9 88.89%
sofa-ark-parent/support/ark-plugin-maven-plugin/src/main/java/com/alipay/sofa/ark/plugin/mojo/ArkPluginMojo.java 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
sofa-ark-parent/support/ark-plugin-maven-plugin/src/main/java/com/alipay/sofa/ark/plugin/mojo/ArkPluginMojo.java 2 0.0%
Totals Coverage Status
Change from base Build 179: 0.4%
Covered Lines: 1107
Relevant Lines: 3455
💛 - Coveralls

straybirdzls
straybirdzls reviewed Apr 23, 2018
View reviewed changes
sofa-ark-parent/core/common/src/test/java/com/alipay/sofa/ark/common/util/ClassUtilsTest.java Outdated
@Test
public void testGetPackageName() {
Assert.assertTrue(ClassUtils.getPackageName("a.b.C").equals("a.b"));
Assert.assertTrue(ClassUtils.getPackageName("C").equals("."));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not use magic number here, better to use DEFAULT_PACKAGE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it has been modified.

@straybirdzls straybirdzls merged commit 632e852 into master Apr 23, 2018
@QilongZhang QilongZhang deleted the enhance_package_rule branch April 23, 2018 09:16
@JoeKerouac JoeKerouac mentioned this pull request Apr 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straybirdzls straybirdzls straybirdzls left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@QilongZhang @coveralls @straybirdzls