Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show linked paths and per-release dependencies in --solve solutions #453

Merged
merged 1 commit into from Jun 24, 2020

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Jun 22, 2020

This PR adds some bits of new info to the output of alr with --solve:

In the graph section of the solution printout, the concrete dependency for each release that brings in another release is now shown. This may help in understanding why a release is chosen (or unsolvable), particularly when there are different restrictions on a same crate introduced by different releases.

For the linked folders with Alire metadata introduced in #450, the source folder is shown in the releases section. Otherwise, such source folders are listed in the externals section without a concrete release (as we cannot determine a version for them).

Example output (from the test) with the new dependency set after the solved milestone:

Dependencies (graph):
   hello=1.0.1      --> libhello=1.0.1 (^1.0)
   superhello=1.0.0 --> libhello=1.0.1 (~1.0)

In the graph section of the solution printout, the concrete dependency for each
release that brings in another release is now shown. This may help in
understanding why a release is chosen, particularly when there are different
restrictions on a same crate introduced by different releases.

For the new linked folders with alire metadata, the source folder is shown in
the releases section. Otherwise, such source folders are listed in the
externals section without a concrete release (as we cannot determine a version
for them).

A new test shows this feature and also shows that the solver is able to
downgrade a dependency whenever this is needed to obtain a complete solution.
@mosteo mosteo marked this pull request as ready for review Jun 22, 2020
@mosteo mosteo requested a review from Fabien-Chouteau Jun 23, 2020
@mosteo mosteo merged commit a9be861 into alire-project:master Jun 24, 2020
@mosteo mosteo deleted the feat/moreinfo branch Jun 24, 2020
@@ -4,6 +4,20 @@ This document is a development diary summarizing changes in `alr` that notably
affect the user experience. It is intended as a one-stop point for users to
stay on top of `alr` new features.

### Show release-specific dependency sets in solutions
Copy link
Member

@Fabien-Chouteau Fabien-Chouteau Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW @mosteo, this is now live on the website: https://alire.ada.dev/docs/#user-facing-changes-log

Copy link
Member Author

@mosteo mosteo Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I had indeed forgotten about updating the website... :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants