Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of an automatic gpr file with #458

Merged
merged 12 commits into from Jul 2, 2020
Merged

Conversation

Fabien-Chouteau
Copy link
Member

@Fabien-Chouteau Fabien-Chouteau commented Jun 26, 2020

When adding or removing dependency with alr with, a list of with statement
for each project files of the dependencies can be automatically added to the
root project file:

-- begin auto-gpr-with --
--  This section was automatically added by Alire
with "libhello.gpr";
-- end auto-gpr-with --
project Test is
...

This feature can be permanently enabled or disabled with a local or global
configuration option:

alr config --global --set auto-gpr-with false

Crates with project files not compatible with this feature can disable it using
the auto-gpr-with entry:

auto-gpr-with=false

ref #313

@Fabien-Chouteau Fabien-Chouteau force-pushed the feat/auto_gpr_with branch 2 times, most recently from e28446b to 224834c Compare Jun 30, 2020
@Fabien-Chouteau Fabien-Chouteau changed the title First prototype implementation of an automatic gpr file with implementation of an automatic gpr file with Jul 1, 2020
@Fabien-Chouteau Fabien-Chouteau marked this pull request as ready for review Jul 1, 2020
@Fabien-Chouteau Fabien-Chouteau requested a review from mosteo Jul 1, 2020
doc/catalog-format-spec.md Outdated Show resolved Hide resolved
.github/workflows/ci-linux.yml Outdated Show resolved Hide resolved
@mosteo
Copy link
Member

mosteo commented Jul 2, 2020

Looks great overall, Fabien, thanks. I just have a couple of doubts that I guess I'm missing by being out of context.

@Fabien-Chouteau
Copy link
Member Author

Fabien-Chouteau commented Jul 2, 2020

Looks great overall, Fabien, thanks.

Thank you, it's a nice to have feature.

I just have a couple of doubts that I guess I'm missing by being out of context.

Are you talking about the comments in your review, or do you have other doubts?

@mosteo
Copy link
Member

mosteo commented Jul 2, 2020

Are you talking about the comments in your review, or do you have other doubts?

Just the comments you already answered 👍

On Windows when using msys2, the make seen by alr can be different than
the one seen from the testsuite scripts. The means that the current way
to identify make's version will fail in some cases.

This patch introduces a different way to workaround the different
version numbers of make.
mosteo
mosteo approved these changes Jul 2, 2020
@mosteo mosteo merged commit 8b908a6 into master Jul 2, 2020
@mosteo mosteo deleted the feat/auto_gpr_with branch Jul 2, 2020
Fabien-Chouteau added a commit to alire-project/alire-index that referenced this pull request Jul 10, 2020
The project file is used for testing and is not supposed to be withed by users.

This way si_units is compatible with alire-project/alire#458.
mosteo pushed a commit to alire-project/alire-index that referenced this pull request Jul 13, 2020
The project file is used for testing and is not supposed to be withed by users.

This way si_units is compatible with alire-project/alire#458.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants