implementation of an automatic gpr file with #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabien-Chouteau
force-pushed
the
feat/auto_gpr_with
branch
2 times, most recently
from
e28446b
to
224834c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This removes duplication of several sources and archives.
Fabien-Chouteau
force-pushed
the
feat/auto_gpr_with
branch
from
85b5d62
to
afd9b34
Compare
Fabien-Chouteau
changed the title
mosteo
reviewed
Jul 2, 2020
mosteo
reviewed
Jul 2, 2020
mosteo
reviewed
Jul 2, 2020
mosteo
reviewed
Jul 2, 2020
|
Looks great overall, Fabien, thanks. I just have a couple of doubts that I guess I'm missing by being out of context. |
Thank you, it's a nice to have feature.
Are you talking about the comments in your review, or do you have other doubts? |
Just the comments you already answered 👍 |
On Windows when using msys2, the make seen by alr can be different than the one seen from the testsuite scripts. The means that the current way to identify make's version will fail in some cases. This patch introduces a different way to workaround the different version numbers of make.
mosteo
approved these changes
Jul 2, 2020
Fabien-Chouteau
added a commit
to alire-project/alire-index
that referenced
this pull request
Jul 10, 2020
The project file is used for testing and is not supposed to be withed by users. This way si_units is compatible with alire-project/alire#458.
mosteo
pushed a commit
to alire-project/alire-index
that referenced
this pull request
Jul 13, 2020
The project file is used for testing and is not supposed to be withed by users. This way si_units is compatible with alire-project/alire#458.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding or removing dependency with
alr with, a list ofwithstatementfor each project files of the dependencies can be automatically added to the
root project file:
This feature can be permanently enabled or disabled with a local or global
configuration option:
alr config --global --set auto-gpr-with falseCrates with project files not compatible with this feature can disable it using
the
auto-gpr-withentry:ref #313