Move ASCII graph to --graph switch, and add a --tree alternative & fallback - #465
Merged
Conversation
Prints dependency graph in tree form, as an alternative to the ascii-art plots that 1) not always will be available, depending in libgraph-easy-perl and 2) quickly become big and broken.
Previously, it was always attempted to be shown with `--solve`, which could be an unnecessary pollution for an otherwise useful command.
mosteo
marked this pull request as ready for review
July 6, 2020 15:17
Fabien-Chouteau
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we attempt to print the ASCII art box graph always at the end of
alr with --solve. This has two problems: one, that wheneasy-graphisn't installed a warning is always emitted. Two, that when installed, that graph can quickly become too large and may difficult using the rest of the output of--solve(which may be the actual part one is interested in).With this PR, this ASCII graph is removed from
--solveand emitted stand-alone using the--graphswitch, for when one is actually interested in that graph.As a fallback for when
easy-graphisn't available, a tree representation is provided:This tree can also be obtained explicitly with
with --tree. It shows in essence the same information than--solve, but because of the explicit branching, it may be more readable in that regard.--solveremains as the "text-only" more detailed output.