Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tarball from Alire workspace #529

Merged
merged 6 commits into from Sep 25, 2020
Merged

Create tarball from Alire workspace #529

merged 6 commits into from Sep 25, 2020

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Sep 15, 2020

A further step towards automating uploading tarballs, when using the --tar switch with alr publish we create the tarball and ask the user to upload it before continuing.

This is still skinny in the sense that no local checks are performed before the upload, so errors are detected a bit late in the process. Also, no attempt is yet made to detect if the release has a corresponding github release to which the file could be uploaded.

  • Implement test
  • Document changes

@mosteo mosteo requested a review from Fabien-Chouteau Sep 15, 2020
@mosteo mosteo force-pushed the feat/tarball branch 2 times, most recently from f3ced88 to 763d402 Compare Sep 15, 2020
src/alire/alire-publish.adb Outdated Show resolved Hide resolved
src/alire/alire-publish.adb Show resolved Hide resolved
src/alire/alire-publish.adb Outdated Show resolved Hide resolved
@mosteo mosteo force-pushed the feat/tarball branch 2 times, most recently from 92dbbdc to 4735e59 Compare Sep 16, 2020
@mosteo mosteo marked this pull request as ready for review Sep 16, 2020
mosteo added 2 commits Sep 17, 2020
It seems GNAT's Normalize_Arguments does its own escaping, so we do not need to
do it ourselves. Also, the test checks that indeed the `alire` folder is
excluded when tar'ing manually.
@mosteo
Copy link
Member Author

mosteo commented Sep 18, 2020

I'd say this one is complete, @Fabien-Chouteau. Do you want it merged before branching for the beta?

@Fabien-Chouteau
Copy link
Member

Fabien-Chouteau commented Sep 18, 2020

Yes we are not ready to fork yet.

@mosteo
Copy link
Member Author

mosteo commented Sep 18, 2020

Then if you're ok with the changes in the two last new commits I'll merge it.

@mosteo mosteo added this to the 0.7 milestone Sep 25, 2020
@mosteo mosteo merged commit 4f6fc2c into master Sep 25, 2020
@mosteo mosteo deleted the feat/tarball branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants