Create tarball from Alire workspace - #529
Merged
Merged
Conversation
54 tasks
mosteo
force-pushed
the
feat/tarball
branch
from
September 15, 2020 16:52
0b169a9 to
70b2510
Compare
mosteo
force-pushed
the
feat/tarball
branch
2 times, most recently
from
September 15, 2020 19:23
f3ced88 to
763d402
Compare
mosteo
force-pushed
the
feat/tarball
branch
2 times, most recently
from
September 16, 2020 10:06
92dbbdc to
4735e59
Compare
mosteo
force-pushed
the
feat/tarball
branch
from
September 16, 2020 10:31
4735e59 to
96daf43
Compare
mosteo
marked this pull request as ready for review
September 16, 2020 11:03
It seems GNAT's Normalize_Arguments does its own escaping, so we do not need to do it ourselves. Also, the test checks that indeed the `alire` folder is excluded when tar'ing manually.
mosteo
force-pushed
the
feat/tarball
branch
from
September 17, 2020 17:11
7e42eef to
5d1f545
Compare
Member
Author
|
I'd say this one is complete, @Fabien-Chouteau. Do you want it merged before branching for the beta? |
Member
|
Yes we are not ready to fork yet. |
Member
Author
|
Then if you're ok with the changes in the two last new commits I'll merge it. |
Fabien-Chouteau
approved these changes
Sep 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A further step towards automating uploading tarballs, when using the
--tarswitch withalr publishwe create the tarball and ask the user to upload it before continuing.This is still skinny in the sense that no local checks are performed before the upload, so errors are detected a bit late in the process. Also, no attempt is yet made to detect if the release has a corresponding github release to which the file could be uploaded.