Add alr publish --manifest <path/to/file.toml> variant#635
Merged
mosteo merged 11 commits intoalire-project:masterfrom Mar 3, 2021
Merged
Add alr publish --manifest <path/to/file.toml> variant#635mosteo merged 11 commits intoalire-project:masterfrom
alr publish --manifest <path/to/file.toml> variant#635mosteo merged 11 commits intoalire-project:masterfrom
Conversation
Fabien-Chouteau
approved these changes
Nov 30, 2020
Member
|
@mosteo do you want this in |
Member
Author
|
No, as I guess once we get feedback from @stcarrez there will be tweaks to make. Also I wouldn't risk breaking something in the regular publishing process this close to release. |
mosteo
force-pushed
the
feat/publish-with-template
branch
2 times, most recently
from
0470864 to
66c9644
Compare
mosteo
force-pushed
the
feat/publish-with-template
branch
from
66c9644 to
8b5a49b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #616.
@stcarrez, I took your PR and added some extra bits to deal with all of our publishing options. In theory it should serve the purpose you wanted as-is, so I would kindly ask that you test it and look for any unexpected behavior. I renamed the
--crateoption to--manifestin the process.More generally, given some convenient changes that were needed for the new switch, now the manifest is checked first thing for missing fields. Also steps can now be reorganized/omitted, for simpler future enhancements (the changes in
Start_At-->Run_Steps).Even if this works as expected, and old and new tests are passing, I would delay merging to post-1.0 just in case there is some breakage.