Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alr publish --manifest <path/to/file.toml> variant #635

Merged
merged 11 commits into from
Mar 3, 2021

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Nov 29, 2020

Supersedes #616.

@stcarrez, I took your PR and added some extra bits to deal with all of our publishing options. In theory it should serve the purpose you wanted as-is, so I would kindly ask that you test it and look for any unexpected behavior. I renamed the --crate option to --manifest in the process.

More generally, given some convenient changes that were needed for the new switch, now the manifest is checked first thing for missing fields. Also steps can now be reorganized/omitted, for simpler future enhancements (the changes in Start_At --> Run_Steps).

Even if this works as expected, and old and new tests are passing, I would delay merging to post-1.0 just in case there is some breakage.

@mosteo mosteo added this to the 2021 milestone Nov 30, 2020
@Fabien-Chouteau
Copy link
Member

@mosteo do you want this in 1.0?

@mosteo
Copy link
Member Author

mosteo commented Feb 5, 2021

No, as I guess once we get feedback from @stcarrez there will be tweaks to make. Also I wouldn't risk breaking something in the regular publishing process this close to release.

@mosteo mosteo marked this pull request as ready for review February 24, 2021 15:45
@mosteo mosteo force-pushed the feat/publish-with-template branch 2 times, most recently from 0470864 to 66c9644 Compare February 24, 2021 16:13
@mosteo mosteo merged commit 3090889 into alire-project:master Mar 3, 2021
@mosteo mosteo deleted the feat/publish-with-template branch March 3, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants