Allow unknown enum values in index manifests and new index --check#656
Merged
Conversation
This allows backwards compatibility for the index, but catches user mistakes.
Fabien-Chouteau
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #650.
By default, unknown enum values are now allowed in the index. This enables us to expand the range of environment values without touching the index version.
Local manifests are always checked, though, for values known to
alr. This way, manual editions to a working manifest by a user cannot result in silently ignored entries.If the user is editing a local index, there is a new option
alire index --checkthat will also load the index using the strict interpretation. The error can be downgraded to a warning with--force. This allows pinpointing problems with index manual editions.We will also run this check in our server tests, to prevent broken submissions (that would have to be created by hand, as
alr publishwouldn't let them through).