Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unknown enum values in index manifests and new index --check #656

merged 4 commits into from Jan 4, 2021


Copy link

@mosteo mosteo commented Dec 29, 2020

Fixes #650.

By default, unknown enum values are now allowed in the index. This enables us to expand the range of environment values without touching the index version.

Local manifests are always checked, though, for values known to alr. This way, manual editions to a working manifest by a user cannot result in silently ignored entries.

If the user is editing a local index, there is a new option alire index --check that will also load the index using the strict interpretation. The error can be downgraded to a warning with --force. This allows pinpointing problems with index manual editions.

We will also run this check in our server tests, to prevent broken submissions (that would have to be created by hand, as alr publish wouldn't let them through).

@mosteo mosteo marked this pull request as ready for review December 30, 2020 00:13
@mosteo mosteo merged commit ccab133 into alire-project:master Jan 4, 2021
@mosteo mosteo deleted the feat/permissive-enums branch January 4, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Should unknown enum values in the index be an error?
2 participants