Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename alr list to alr crates #671

Merged
merged 8 commits into from
Feb 1, 2021
Merged

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Jan 28, 2021

Fixes #369.

Hopefully this makes more clear that alr crates operates at crate level while alr search looks into releases.

This way there is less confusion about the purposes of `alr crates` and `alr
search`; the former operates on crates and the latter on releases.
@mosteo mosteo marked this pull request as ready for review January 28, 2021 16:14
@Fabien-Chouteau
Copy link
Member

Why not remove alr list/alr crate altogether? And put the same functionality in an alr search --list-all.

@mosteo
Copy link
Member Author

mosteo commented Jan 29, 2021

Why not remove alr list/alr crate altogether? And put the same functionality in an alr search --list-all.

Given that that would produce an entirely different listing, I find that more confusing. Also alr search --list already lists releases.

What about having alr search --crates to signal that we want to look into crates instead of releases (as if a currently non-existent --releases were the default). Then the same --list that currently looks into releases could be reused.

@Fabien-Chouteau
Copy link
Member

Ok for me. But I think that the difference between list of crates and list of release will always be a bit confusing.

@mosteo
Copy link
Member Author

mosteo commented Jan 29, 2021

Updated with the alr search --crates option.

@mosteo mosteo merged commit c763b00 into alire-project:master Feb 1, 2021
@mosteo mosteo deleted the fix/list branch February 1, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alr list vs alr search --list
2 participants