Automatically narrow down dependencies given as "any"#675
Merged
Conversation
Contributor
Yarn will use |
Member
Author
|
Thanks for the precision, @onox. I think the end result is similar (at least for regular crates... The idea of peer/host crates is new to me). |
Instead of adding just a foo* dependency, check how it was solved and use that version to add a more precise (and usually wanted) dependency; e.g., foo^1.2, foo~0.1
Many tests explicitly check the added dependencies, so this is extra assurance about this change.
mosteo
force-pushed
the
feat/narrowdep
branch
from
e3db064 to
67b31e7
Compare
Fabien-Chouteau
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think
npmalso works like this. When a user adds a dependency without giving a version range, after this PR we use the solved version to narrow down the dependency to be added to what the user probably intends. E.g.:alr with foopreviously resulted infoo*being added; now it will result in eitherfoo~0.xorfoo^x.y, etc being presented as the requested dependency.A
*dependency can still be added by requesting it explicitly withalr with 'foo>=0'(or manually editing, of course).This may merit a config option to disable this behavior.