Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New action subcommand #983

Merged
merged 5 commits into from Apr 14, 2022
Merged

New action subcommand #983

merged 5 commits into from Apr 14, 2022

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Apr 12, 2022

No need to review yet as tests are still missing.

This PR adds a new subcommand, alr action, to allow listing and manual triggering of actions and so help with their development/debugging.

alr action simply lists any actions defined.

alr action post-fetch and similar trigger the associated actions.

Adding the --recursive flag will list/trigger in dependencies too.

I ditched the idea discussed elsewhere of having a custom action type, since it would likely consist in running an script, and alr exec already covers that use case.

@mosteo mosteo marked this pull request as ready for review April 12, 2022 22:16
Copy link
Member

@Fabien-Chouteau Fabien-Chouteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I think we should reconsider the post-fetch action. See https://go.dev/blog/supply-chain

@mosteo
Copy link
Member Author

mosteo commented Apr 14, 2022

BTW, I think we should reconsider the post-fetch action. See https://go.dev/blog/supply-chain

Lots of interesting info in that link. But how will we deal with anything requiring a makefile or extra tool? We could have some kind of safe mode where actions cause an error instead of being run.

I find most interesting the bit about not automatically updating and making transitive dependencies explicit.

@mosteo mosteo merged commit b12a2e3 into alire-project:master Apr 14, 2022
@mosteo mosteo deleted the feat/action-cmd branch April 14, 2022 09:06
@Fabien-Chouteau
Copy link
Member

Lots of interesting info in that link. But how will we deal with anything requiring a makefile or extra tool? We could have some kind of safe mode where actions cause an error instead of being run.

Or a user query that shows the action that will be executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants