Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Need styles for `dl`, `dd`, `dt` #7

Closed
Wilto opened this Issue Jan 14, 2014 · 11 comments

Comments

Projects
None yet
7 participants
Member

Wilto commented Jan 14, 2014

Quite a few very old articles use dl, dd, and dt, sometimes for very large swathes of an article—at the moment, they’re not styled very well. @murtaugh, you have any links to those articles kicking around?

@ghost ghost assigned murtaugh Jan 14, 2014

Contributor

maxfenton commented Jan 15, 2014

@Wilto I spent maybe 15 minutes looking for posts that have this, but couldn't find any. @murtaugh is there a way to search through the DB to find a <dl> to get an example or two?

Owner

murtaugh commented Jan 15, 2014

Here’s one:

http://alistapart.com/article/business1#section17

They’re really only used in very old articles. They fell out of favor some time ago.

On Jan 15, 2014, at 12:35 PM, Max Fenton notifications@github.com wrote:

@Wilto I spent maybe 15 minutes looking for posts that have this, but couldn't find any. @murtaugh is there a way to search through the DB to find a

to get an example or two?

Reply to this email directly or view it on GitHub.

Contributor

maxfenton commented Jan 23, 2014

Thanks, @murtaugh.

Is this still in process? While we move old articles into the new system, perhaps this will become a more pronounced issue.

Owner

murtaugh commented Jun 19, 2014

@mikepick, if you could take a look at this it would be great.

@murtaugh murtaugh assigned mikepick and unassigned murtaugh Jun 19, 2014

Member

mikepick commented Jun 20, 2014

Not sure what to do here as it is only one instance and I'm thinking that other instances may be different content contexts (which is why using DL as a catch-all for paired lists is dumb.)

What is the default or general style for these? That's what I would go with, just so they don't look quite so unstyled.

Owner

murtaugh commented Jun 20, 2014

I really don’t know what a general style should be.

On Jun 20, 2014, at 1:07 PM, Mike Pick notifications@github.com wrote:

Not sure what to do here as it is only one instance and I'm thinking that other instances may be different content contexts (which is why using DL as a catch-all for paired lists is dumb.)

What is the default or general style for these? That's what I would go with, just so they don't look quite so unstyled.


Reply to this email directly or view it on GitHub.

Owner

murtaugh commented Jun 20, 2014

Here's the dl in my example link in the previous layout:

screen shot 2014-06-20 at 1 32 08 pm

http://v4.alistapart.com/articles/business1

Contributor

beep commented Dec 3, 2014

The problem in http://alistapart.com/article/business1 seems to be there’s a whole bunch of &nbsp;s before each dd. (i.e., outside the dt/dd pairs) This is causing some weird spacing between the rows.

There’s obviously additional style work that could happen, but it seems like a quick fix would be to clean up the article markup.

Owner

murtaugh commented Dec 3, 2014

I cleaned up the article’s markup a bit, looks a bit better. I also added a font-weight to the dts.

The general problem with dl, dd, dt for us is that for a time we (developers in general) were using them in place of tables (when tables were evil), and we’d jump through some real hoops to get them to behave how we wanted, so there are a bunch of dls in articles that defy a standard application of styles.

On Dec 2, 2014, at 11:26 PM, beep notifications@github.com wrote:

The problem in http://alistapart.com/article/business1 http://alistapart.com/article/business1 seems to be there’s a whole bunch of  s before each dd. (i.e., outside the dt/dd pairs) This is causing some weird spacing between the rows.

There’s obviously additional style work that could happen, but it seems like a quick fix would be to clean up the article markup.


Reply to this email directly or view it on GitHub #7 (comment).

@michellekondou michellekondou added minor bug and removed critical labels Feb 13, 2015

Closing, as this is an evolution of development, rather than a bug.

@aparkening aparkening closed this Feb 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment