From 7740a95b69d7aa182c7df3bef9bba1dd0fb91180 Mon Sep 17 00:00:00 2001 From: Itai Steinherz Date: Wed, 25 Jan 2017 18:27:40 +0200 Subject: [PATCH] test: Update question emoji in tests (#27) * Update format-contribution-type.test.js Updated the expected question emoji. * Update format-contributor.test.js Updated the expected question emoji. * Add @itaisteinherz as a contributor --- .all-contributorsrc | 9 +++++++++ README.md | 6 +++--- lib/generate/format-contribution-type.test.js | 2 +- lib/generate/format-contributor.test.js | 2 +- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 3f9975d8..c791d667 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -41,6 +41,15 @@ "contributions": [ "code" ] + }, + { + "login": "itaisteinherz", + "name": "Itai Steinherz", + "avatar_url": "https://avatars.githubusercontent.com/u/22768990?v=3", + "profile": "https://github.com/itaisteinherz", + "contributions": [ + "code" + ] } ] } diff --git a/README.md b/README.md index fbee5edf..fe1df66a 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # all-contributors-cli -[![version](https://img.shields.io/npm/v/all-contributors-cli.svg)](http://npm.im/all-contributors-cli)[![All Contributors](https://img.shields.io/badge/all_contributors-4-orange.svg?style=flat-square)](#contributors) +[![version](https://img.shields.io/npm/v/all-contributors-cli.svg)](http://npm.im/all-contributors-cli)[![All Contributors](https://img.shields.io/badge/all_contributors-5-orange.svg?style=flat-square)](#contributors) This is a tool to help automate adding contributor acknowledgements according to the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. @@ -88,8 +88,8 @@ These are the keys you can specify: Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds/all-contributors#emoji-key)): -| [
Jeroen Engels](https://github.com/jfmengels)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [⚠️](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) | [
Kent C. Dodds](http://kentcdodds.com/)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) | [
JoΓ£o GuimarΓ£es](https://github.com/jccguimaraes)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jccguimaraes) | [
Ben Briggs](http://beneb.info)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=ben-eb) | -| :---: | :---: | :---: | :---: | +| [
Jeroen Engels](https://github.com/jfmengels)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) [⚠️](https://github.com/jfmengels/all-contributors-cli/commits?author=jfmengels) | [
Kent C. Dodds](http://kentcdodds.com/)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) | [
JoΓ£o GuimarΓ£es](https://github.com/jccguimaraes)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=jccguimaraes) | [
Ben Briggs](http://beneb.info)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=ben-eb) | [
Itai Steinherz](https://github.com/itaisteinherz)
[πŸ’»](https://github.com/jfmengels/all-contributors-cli/commits?author=itaisteinherz) | +| :---: | :---: | :---: | :---: | :---: | This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. diff --git a/lib/generate/format-contribution-type.test.js b/lib/generate/format-contribution-type.test.js index 43413eb6..a0ce89b0 100644 --- a/lib/generate/format-contribution-type.test.js +++ b/lib/generate/format-contribution-type.test.js @@ -16,7 +16,7 @@ test('should return corresponding symbol', t => { const {options} = fixtures(); t.is(formatContributionType(options, contributor, 'tool'), 'πŸ”§'); - t.is(formatContributionType(options, contributor, 'question'), 'πŸ’'); + t.is(formatContributionType(options, contributor, 'question'), 'πŸ’¬'); }); test('should return link to commits', t => { diff --git a/lib/generate/format-contributor.test.js b/lib/generate/format-contributor.test.js index 7c10785a..fa6cae01 100644 --- a/lib/generate/format-contributor.test.js +++ b/lib/generate/format-contributor.test.js @@ -25,7 +25,7 @@ test('should format contributor with complex contribution types', t => { const contributor = contributors.kentcdodds; const {options} = fixtures(); - const expected = '[
Kent C. Dodds](http://kentcdodds.com)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) πŸ‘€ πŸ’'; + const expected = '[
Kent C. Dodds](http://kentcdodds.com)
[πŸ“–](https://github.com/jfmengels/all-contributors-cli/commits?author=kentcdodds) πŸ‘€ πŸ’¬'; t.is(formatContributor(options, contributor), expected); });