Fixes #36 | Add systemd config #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,6 +73,7 @@ consul-tag | `marathon` | Common tag name added to every | |||
| listen | `:4000` | Accept connections at this address | |||
| log-level | `info` | Log level: panic, fatal, error, warn, info, or debug | |||
| log-format | `text` | Log format: JSON, text | |||
| log-format | | Save logs to file (e.g.: `/var/log/marathon-consul.log`). If empty logs are published to STDERR | |||
|
👍 |
janisz
force-pushed
the
add_systemd_service
branch
from
45ebb65
to
91f2bca
Compare
| @@ -37,6 +37,7 @@ | |||
| }, | |||
| "Log": { | |||
| "Level": "info", | |||
| "Format": "text" | |||
| "Format": "text", | |||
| "File": "" | |||
There was a problem hiding this comment.
maybe we should set something like /var/log/marathon-consul.log as default?
There was a problem hiding this comment.
By default it's stderr, it could not work with systemd but works perfect with upstart
janisz
force-pushed
the
add_systemd_service
branch
from
91f2bca
to
37b5a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd doesn't forward output to file so I added config option to write logs to file.