Fix duplicate hostname #3295
Merged
Fix duplicate hostname #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurek
reviewed
Aug 6, 2018
| from ralph.dhcp.models import DHCPEntry | ||
| entries_with_hostname = DHCPEntry.objects.filter( | ||
| hostname=hostname, | ||
| dhcp_expose=True, |
There was a problem hiding this comment.
no need to filter it - it's already handled by DHCPEntry's manager
| @@ -662,6 +662,32 @@ class Meta: | |||
| def __str__(self): | |||
| return self.address | |||
|
|
|||
| def hostname_is_unique_in_dc(self, hostname, dc): | |||
| from ralph.dhcp.models import DHCPEntry | |||
| entries_with_hostname = DHCPEntry.objects.filter( | |||
There was a problem hiding this comment.
shouldn't we exclude here current ip address (by its pk)?
mkurek
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two IPs have the same hostname in DHCP, one is ignored. This PR adds validation of such scenario when "expose in DHCP" is selected while creating or updating IP address.