Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ssh_xen plugin - UnicodeDecodeError fixed #520

Merged
merged 2 commits into from Apr 5, 2013

Conversation

Projects
None yet
2 participants
Member

andrzej-jankowski commented Apr 3, 2013

No description provided.

@vi4m vi4m commented on an outdated diff Apr 4, 2013

src/ralph/discovery/plugins/ssh_xen.py
@@ -47,6 +47,10 @@ def get_macs(ssh):
macs = collections.defaultdict(set)
label = ''
for line in _ssh_lines(ssh, 'sudo xe vif-list params=vm-name-label,MAC'):
+ try:
+ line = unicode(line, 'utf-8')
@vi4m

vi4m Apr 4, 2013

Owner

why not

>>> unicode("a\x81test", "utf-8","ignore")
atest
Owner

vi4m commented Apr 5, 2013

OK

@vi4m vi4m pushed a commit that referenced this pull request Apr 5, 2013

Marcin Kliks Merge pull request #520 from andrzej-jankowski/discovery
ssh_xen plugin - UnicodeDecodeError fixed
254cad8

@vi4m vi4m merged commit 254cad8 into allegro:master Apr 5, 2013

@andrzej-jankowski andrzej-jankowski pushed a commit to andrzej-jankowski/ralph that referenced this pull request Sep 26, 2013

Marcin Kliks Merge pull request #520 from andrzej-jankowski/discovery
ssh_xen plugin - UnicodeDecodeError fixed
1f25520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment