Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inactive players on player list #64

Closed
allejo opened this issue Nov 3, 2016 · 1 comment

Comments

@allejo
Copy link
Owner

commented Nov 3, 2016

The player page displays all of the players, whether they are active or inactive. Similar to the matches and team pages, the player page should show only active players by default and then have the option to list all players.

An active player is defined as a player who has logged in to the website or has played a match in the last X months.

  • Add configuration option to define the "active" time period
  • Add a last_match to the Player object
  • Write a migration for this column; the migration should also look up the most recent match and set that
  • League Overseer hook should update the last_match for each player in the match
  • Modify the player list view to only show active players based on last_match or last_login, whichever is more recent

/related #28

@allejo allejo added this to the Version 1.0.0 milestone Nov 3, 2016
@allejo allejo self-assigned this Nov 3, 2016
@allejo allejo modified the milestones: Version 0.9.3, Version 1.0.0 Nov 5, 2016
allejo added a commit that referenced this issue Nov 12, 2016
- Migration has been written
- Player object updated to store this information
- Display link to last match on player profiles
- Refers to #64
allejo added a commit that referenced this issue Nov 12, 2016
- Migration has been written
- Player object updated to store this information
- Display link to last match on player profiles
- Refers to #64
@allejo

This comment has been minimized.

Copy link
Owner Author

commented Nov 13, 2016

I'm leaving this open for now. This should be optimized in the controller and not rely on Twig filtering

@allejo allejo referenced this issue Jul 14, 2017
9 of 9 tasks complete
@allejo allejo closed this in #80 Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.