Skip to content
Browse files

add option "-k" to limit tests in test-install command (#2635)

* add option "-k" to limit tests in test-install command

* remove "not notebooks_test" argument

* explicit is better than a comment

* Remove last reference to notebook tests

* Simplify nesting
  • Loading branch information...
mfa authored and matt-gardner committed Mar 22, 2019
1 parent 1357c7e commit c06e904588503768331a580d8766bf4a47f83574
Showing with 16 additions and 5 deletions.
  1. +16 −5 allennlp/commands/
@@ -40,6 +40,8 @@ def add_subparser(self, name: str, parser: argparse._SubParsersAction) -> argpar
subparser.add_argument('--run-all', action="store_true",
help="By default, we skip tests that are slow "
"or download large files. This flag will run all tests.")
subparser.add_argument('-k', type=str, default=None,
help="Limit tests by setting pytest -k argument")


@@ -57,12 +59,21 @@ def _run_test(args: argparse.Namespace):
test_dir = os.path.join(module_parent, "allennlp")"Running tests at %s", test_dir)
if args.run_all:
# TODO(nfliu): remove this when notebooks have been rewritten as markdown.
exit_code = pytest.main([test_dir, '--color=no', '-k', 'not notebooks_test'])

if args.k:
pytest_k = ['-k', args.k]
pytest_m = ['-m', 'not java']
if args.run_all:
logger.warning("the argument '-k' overwrites '--run-all'.")
elif args.run_all:
pytest_k = []
pytest_m = []
exit_code = pytest.main([test_dir, '--color=no', '-k', 'not sniff_test and not notebooks_test',
'-m', 'not java'])
pytest_k = ['-k', 'not sniff_test']
pytest_m = ['-m', 'not java']

exit_code = pytest.main([test_dir, '--color=no'] + pytest_k + pytest_m)

# Change back to original working directory after running tests

0 comments on commit c06e904

Please sign in to comment.
You can’t perform that action at this time.