Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to restart with optimizers on CUDA #1144

Merged
merged 3 commits into from Apr 26, 2018

Conversation

@matt-peters
Copy link
Contributor

commented Apr 26, 2018

No description provided.

matt-peters added 2 commits Apr 26, 2018
@matt-peters

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

Fixes #998 #1102

@matt-peters matt-peters requested a review from DeNeutoy Apr 26, 2018

@DeNeutoy

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2018

Great, thanks - could you add a todo to check if this is necessary with the 0.4 upgrade?

@matt-peters

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

Opened #1146 to track whether this is necessary after moving to 0.4.

@matt-peters matt-peters merged commit 6d15d17 into allenai:master Apr 26, 2018

2 of 3 checks passed

codecov/patch 55% of diff hit (target 90%)
Details
Pull Requests (AllenNLP) TeamCity build finished
Details
codecov/project 92% (-1%) compared to c684216
Details

@matt-peters matt-peters deleted the matt-peters:optimizer_cuda_restart branch Apr 26, 2018

gabrielStanovsky pushed a commit to gabrielStanovsky/allennlp that referenced this pull request Sep 7, 2018
Allow to restart with optimizers on CUDA (allenai#1144)
* Allow to restart with optimizers on CUDA

* pylint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.