Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ELMo command help docstring #1195

Merged
merged 1 commit into from May 11, 2018

Conversation

@nelson-liu
Copy link
Member

commented May 10, 2018

just ran allennlp elmo --help and updated the output.

@nelson-liu nelson-liu requested a review from schmmd May 10, 2018

@nelson-liu

This comment has been minimized.

Copy link
Member Author

commented May 10, 2018

while i'm here: I'm interested in getting lowercased elmo vectors from allennlp elmo. is this part of options_file, or should I add a flag to the command?

@matt-peters

This comment has been minimized.

Copy link
Contributor

commented May 11, 2018

We don't support lowercased vectors as ELMo is purely character based and was trained without lowercasing or other character normalization. What is your use case for lowercased vectors?

@nelson-liu

This comment has been minimized.

Copy link
Member Author

commented May 11, 2018

I’m interested in reproducing the functionality of the following snippet with lowercase_tokens set to True

 "dataset_reader": {
   "type": "srl",
   "token_indexers": {
     "tokens": {
       "type": "single_id",
       "lowercase_tokens": true
     },
     "elmo": {
       "type": "elmo_characters"
     }
   }
 }
@matt-peters

This comment has been minimized.

Copy link
Contributor

commented May 11, 2018

It may be useful for lowercasing tokens with word vectors such as GloVe that were trained with lowercased tokens, but for ELMo it's not necessary which is why we haven't implemented it.

@nelson-liu

This comment has been minimized.

Copy link
Member Author

commented May 11, 2018

ah got it, thanks --- misunderstood the purpose of that argument. Feel free to merge this as is whenever.

@schmmd
schmmd approved these changes May 11, 2018

@schmmd schmmd merged commit 63f2108 into allenai:master May 11, 2018

3 checks passed

Pull Requests (AllenNLP) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing 8ba5867...9ef1376
Details
codecov/project 92% remains the same compared to 8ba5867
Details
@schmmd

This comment has been minimized.

Copy link
Member

commented May 11, 2018

Thanks!

@nelson-liu nelson-liu deleted the nelson-liu:elmo-help branch May 11, 2018

gabrielStanovsky pushed a commit to gabrielStanovsky/allennlp that referenced this pull request Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.