This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Allow server start without field-names. #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelgrus can you review this pr? |
joelgrus
approved these changes
Jul 26, 2018
|
@joelgrus would you merge this PR down? |
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
* Allow server start without field-names. * Allow server to turn ON w/o field-name, static_dir * Fix a typo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand, there are three ways of using simple server:
field-names are passed and it generates barebone html with those field names to be used in demo.static-diris passed thenfield-nameis not required. The static html should have the required field-names as input fields.static-dir, norfield-nameis required.Except use-case (1),
field-nameargument should not be required. I am using (3) and I couldn't start text-in/text-out service on without passing some field-name which would in fact get ignored.Edit1: WIP
Edit2: Seems OK now.