Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptick cffi to 1.11.5 #1846

Merged
merged 7 commits into from Oct 16, 2018

Conversation

@schmmd
Copy link
Member

commented Oct 1, 2018

Fixes #1824

@schmmd

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2018

This failed due to the notebook tests. They failed with a RuntimeError: Kernel died before replying to kernel_info.

We saw this same error (although for a different reason) in another PR https://github.com/allenai/allennlp/pull/1836/files#diff-b4ef698db8ca845e5845c4618278f29aR104

schmmd added 3 commits Oct 1, 2018
schmmd added 2 commits Oct 16, 2018

@schmmd schmmd merged commit 2ec52a5 into allenai:master Oct 16, 2018

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing 0e47d16...7f93e0f
Details
codecov/project 92% (-1%) compared to 0e47d16
Details
nelson-liu added a commit to allenai/allennlp-feedstock that referenced this pull request Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.