Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tqdm when there isn't a TTY #1927

Merged
merged 3 commits into from Oct 25, 2018
Merged

Disable tqdm when there isn't a TTY #1927

merged 3 commits into from Oct 25, 2018

Conversation

@DeNeutoy
Copy link
Collaborator

DeNeutoy commented Oct 19, 2018

@splittingfield FYI. This won't take much effect until the next release but 🤷‍♂️

Mark Neumann
@DeNeutoy DeNeutoy requested a review from joelgrus Oct 19, 2018
# If we don't have a terminal as stdout,
# force tqdm to be nicer.
if not sys.stdout.isatty():
file_friendly_logging = True

This comment has been minimized.

Copy link
@joelgrus

joelgrus Oct 19, 2018

Collaborator

is there ever a case where you'd want file_friendly_logging in a terminal?

that is, with this change can we just get rid of the file_friendly_logging config parameter everywhere?

This comment has been minimized.

Copy link
@matt-peters

matt-peters Oct 19, 2018

Contributor

I use file_friendly_logging with a terminal.

@schmmd

This comment has been minimized.

Copy link
Member

schmmd commented Oct 22, 2018

@DeNeutoy love it!

@schmmd schmmd changed the title stronger fix for tqdm for beaker Disable tqdm when there isn't a TTY Oct 25, 2018
@schmmd schmmd merged commit 26f09cf into allenai:master Oct 25, 2018
3 checks passed
3 checks passed
Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +7% compared to b529f6d
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.