Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix epoch tracking #2121

Merged
merged 2 commits into from Nov 30, 2018

Conversation

@joelgrus
Copy link
Contributor

commented Nov 30, 2018

fixes #2120

@joelgrus joelgrus requested a review from DeNeutoy Nov 30, 2018

@DeNeutoy
Copy link
Contributor

left a comment

LGTM (sorry that issue wasn't designed to be pointing a finger at you, I just noticed that PR was where it came from)

@joelgrus joelgrus merged commit 3a7e065 into allenai:master Nov 30, 2018

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 92% (+0%) compared to db0096f
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.