Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatches between setup.py and requirements.txt #2157

Merged
merged 1 commit into from Dec 9, 2018

Conversation

@epwalsh
Copy link
Contributor

commented Dec 9, 2018

cffi and flask-cors were behind in setup.py

@epwalsh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2018

Also, I should mention that I found this by running ./scripts/verify.py because .scripts/check_requirements_and_setup.py failed. But I was surprised that this wasn't caught in a TeamCity build. I guess I assumed that TeamCity just ran ./scripts/verify.py, but I guess that isn't the case?

@joelgrus
Copy link
Contributor

left a comment

thanks

@joelgrus

This comment has been minimized.

Copy link
Contributor

commented Dec 9, 2018

TeamCity runs the verify checks individually in different steps (which makes it easier to see which ones fail and where), but I guess it doesn't run all of them, we should check that.

@joelgrus joelgrus merged commit 2e412e3 into allenai:master Dec 9, 2018

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing a75cb0a...0ca5069
Details
codecov/project 92% remains the same compared to a75cb0a
Details

@epwalsh epwalsh deleted the epwalsh:fix-requirements-mismatch branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.