New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc: clarify the "num_output_representations" more clear #2256

Merged
merged 3 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@ShomyLiu
Copy link
Contributor

ShomyLiu commented Dec 28, 2018

For issue #2245
modify confusing explanation about the parameter num_output_representations in ELMo class and add some comments about the example code in
https://github.com/allenai/allennlp/blob/master/tutorials/how_to/elmo.md#using-elmo-as-a-pytorch-module-to-train-a-new-model

@nelson-liu thanks.

@ShomyLiu ShomyLiu changed the title clarify the "num_output_representations" more clear Fix doc: clarify the "num_output_representations" more clear Dec 29, 2018

matt-peters added some commits Jan 2, 2019

@matt-peters matt-peters merged commit 07d193e into allenai:master Jan 2, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing ee02ed0...bad618f
Details
codecov/project 92% remains the same compared to ee02ed0
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment