Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check train/dev/test-file-path before process #2308

Merged
merged 2 commits into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@WrRan
Copy link
Contributor

WrRan commented Jan 8, 2019

Fixes #2295.

if not os.path.exists(file_path):
raise ConfigurationError(f"Experiment specified {dataset_name}, "
f"but {file_path} doesn't exist.")
if not os.path.isfile(file_path):

This comment has been minimized.

Copy link
@matt-gardner

matt-gardner Jan 8, 2019

Member

I don't think we can do this check - we allow for the path to be a directory.

@matt-gardner
Copy link
Member

matt-gardner left a comment

Thanks!

@matt-gardner matt-gardner merged commit 8a7f808 into allenai:master Jan 9, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch 90% of diff hit (target 90%)
Details
codecov/project 92% (-1%) compared to 088f0bb
Details
@brendan-ai2

This comment has been minimized.

Copy link
Member

brendan-ai2 commented Jan 11, 2019

This breaks the multiprocess dataset reader which expects to receive a glob.

brendan-ai2 added a commit that referenced this pull request Jan 18, 2019

Rollback PR #2308 "Check train/dev/test-file-path" (#2386)
- This breaks the `MultiprocessDatasetReader` which relies on globs.
- Test to prevent regressing.
- The motivation behind PR #2308 is good, but we need to be a bit more sophisticated in how we perform the check. Perhaps `DatasetReader` should provide an optional `check_path` method that users can override?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.