Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links for some tutorials and organized the How-to alphabetically. #2315

Merged
merged 7 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@DumbMachine
Copy link
Contributor

commented Jan 9, 2019

Added links for Tutorials for the following:
Creating a Configuration File.
Using a Debugger.
Training and Using a Transformer ELMo.

Fixes #2284

added links for some tutorials
Added links for Tutorials  for the following:
    Creating a Configuration File.
    Using a Debugger.
    Training and Using a Transformer ELMo.
Show resolved Hide resolved tutorials/README.md Outdated
@nelson-liu
Copy link
Member

left a comment

Thanks for this! Sorry, but while you're at it, can you sort the how-to articles in alphabetical order (for consistency with the other sections)?

DumbMachine added some commits Jan 9, 2019

@DumbMachine DumbMachine changed the title added links for some tutorials. Added links for some tutorials and organized the How-to alphabetically. Jan 9, 2019

@nelson-liu
Copy link
Member

left a comment

Sorry, last two nitpicks and then it'll be good to go. thanks again

* [How to train a model with lazy data](how_to/laziness.md)
* [How to train and use a Transformer ELMo](how_to/training_transformer_elmo.md)
* [How to use a Debugger](how_to/using_a_debugger.md)

This comment has been minimized.

Copy link
@nelson-liu

nelson-liu Jan 9, 2019

Member

last nitpicks, i think this link title would be better as How to Debug Your AllenNLP Code.

This comment has been minimized.

Copy link
@DumbMachine

DumbMachine Jan 9, 2019

Author Contributor

Done. 😊

Show resolved Hide resolved tutorials/README.md Outdated
* [How to train a model with lazy data](how_to/laziness.md)
* [How to train and use a Transformer ELMo](how_to/training_transformer_elmo.md)
* [How to Debug Your AllenNLP Coder](how_to/using_a_debugger.md)

This comment has been minimized.

Copy link
@nelson-liu

nelson-liu Jan 9, 2019

Member

looks like Coder should be Code?

DumbMachine added some commits Jan 9, 2019

Small change
Change the title of an how to; from : How to train and use a Transformer ELMo , to: How to train and use a Transformer-based ELMo.

@nelson-liu nelson-liu merged commit 36d7400 into allenai:master Jan 9, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing f160059...90c301e
Details
codecov/project 92% remains the same compared to f160059
Details
@nelson-liu

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Thanks @DumbMachine , much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.