Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_a_configuration.md howto by removing old allennlp configure #2330

Merged
merged 5 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@nelson-liu
Copy link
Member

commented Jan 10, 2019

@joelgrus is there any way to access the old functionality of allennlp configure? or was it completely removed?

I've updated the create_a_configuration tutorial for the latter case, but happy to just edit run commands if the functionality is still around.

@nelson-liu nelson-liu requested a review from joelgrus Jan 10, 2019

@joelgrus

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

I removed the cli part, but it's not very much code:

https://github.com/allenai/allennlp/pull/2118/files#diff-cd8c2aa70e36ddf3bdd444d50027bbb5L36

it should be not much work to create a script that does the same

@schmmd

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

@nelson-liu care to merge this down?

@nelson-liu

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Sure! sorry, it must have fallen off my radar.

nelson-liu added some commits Jan 15, 2019

@nelson-liu nelson-liu merged commit abc10ed into allenai:master Jan 16, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing 083f49e...a9215c5
Details
codecov/project 92% remains the same compared to 083f49e
Details

@nelson-liu nelson-liu deleted the nelson-liu:update_configuration_howto branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.